Fix some little problems#2
Open
gaunthan wants to merge 2 commits intoIRIM-Technology-Transition-Lab:masterfrom
Open
Fix some little problems#2gaunthan wants to merge 2 commits intoIRIM-Technology-Transition-Lab:masterfrom
gaunthan wants to merge 2 commits intoIRIM-Technology-Transition-Lab:masterfrom
Conversation
gaunthan
commented
May 9, 2019
gaunthan
commented
- The package name for 'cv2' should be 'opencv-python'
- Porting to python 3
- Allow the directory of input/output to be outside of the working directory
|
@mjsobrep @varunagrawal Could you please merge this pull request? |
Author
|
您的来信我已收到，我会尽快回复。
|
mjsobrep
requested changes
Mar 15, 2022
Member
mjsobrep
left a comment
mjsobrep
left a comment
There was a problem hiding this comment.
just one small change: sanitize directory input.
| target_directory = os.path.join(os.getcwd(), directory) | ||
| directory_out = os.path.join(os.getcwd(), directory_out) | ||
| print "Searching for images in: " + target_directory | ||
| target_directory = directory |
Member
There was a problem hiding this comment.
should sanitize with expand user
| print("Found Images:") | ||
| for name in file_names: | ||
| print "\t" + name | ||
| print("\t" + name) |
Member
There was a problem hiding this comment.
would be great to at some point change all of these to f-strings, but not critical
Member
|
@aparico I'm mostly OK with this. Just need to add something to the directory to appropriately sanitize it. Have you tested the changes? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.